Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create_CustomSentinel2Tiler.ipynb notebook is broken #208

Closed
drnextgis opened this issue Feb 3, 2021 · 2 comments · Fixed by #209
Closed

Create_CustomSentinel2Tiler.ipynb notebook is broken #208

drnextgis opened this issue Feb 3, 2021 · 2 comments · Fixed by #209
Labels
bug Something isn't working

Comments

@drnextgis
Copy link
Contributor

  • in the first section "Create the CustomTiler" instead of from titiler.models.dataset import Info, Metadata should be from rio_tiler.models import Info, Metadata
  • optquery variable is not defined
@drnextgis drnextgis added the bug Something isn't working label Feb 3, 2021
@drnextgis
Copy link
Contributor Author

Thanks @vincentsarago, great job! We are planing to start using Titiler here so in order to be more familiar with code I'm going to pick something else to fix from the backlog.

@vincentsarago
Copy link
Member

thanks @drnextgis

so in order to be more familiar with code I'm going to pick something else to fix from the backlog.

We are always looking for contribution on the DOC side. Like I really want to add docstring (google style) to all the methods/function so we can add API documentation in the online doc. Other documentation update would be really appreciated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants