Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Atmos audio is not always selected / prioitized #107

Open
Dreamer269 opened this issue Apr 27, 2024 · 0 comments
Open

Atmos audio is not always selected / prioitized #107

Dreamer269 opened this issue Apr 27, 2024 · 0 comments

Comments

@Dreamer269
Copy link

Describe the bug
Some services have Atmos audio with a lower bitrate than the normal audio tracks. For example, normal E-AC-3 640 kb/s vs. atmos E-AC-3 448 kb/s.

To Reproduce
Steps to reproduce the behavior:

  1. Download a title with Atmos audio from the service.

Expected behavior
Since atmos is considered superior, it should be selected instead of the 640 kb/s audio track.

Additional context
This seems to be caused by the following code in sort_audio (tracks.py):

        self.audio.sort(
            key=lambda x: float(x.bitrate or 0.0),
            reverse=True
        )```
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant