Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cancelling semi-broken with ara2c downloader #80

Open
rlaphoenix opened this issue Mar 8, 2024 · 0 comments
Open

Cancelling semi-broken with ara2c downloader #80

rlaphoenix opened this issue Mar 8, 2024 · 0 comments
Labels
bug Something isn't working

Comments

@rlaphoenix
Copy link
Member

Describe the bug
Pressing CTRL+C to try break/cancel the download instead just cancels the track that was downloading only, instead of all tracks.
It also doesn't ever mark the track as CANCELLING or CANCELLED or anything like that. It just leaves the last download speed value set.
This seems to have been a bug introduced with changes in v3.0.0 regarding the rework to the downloaders and DASH/HLS download systems.

Expected behavior
Pressing CTRL+C should stop segments/singular file downloads as soon as possible, mark the track as CANCELLING in yellow, then once it has stopped mark as CANCELLED in yellow. Then skip all tracks afterwards marking them as CANCELLED in yellow.

Screenshots
image

Additional context
In the above screenshot I let the Video track finish, but cancelled the Audio track near the end and subtitles a bit after they started. Where the progress bar is visually is about where I pressed CTRL+C. The time at which it tries to stop the current track is working and correct, just it doesn't update the progress bar or cancel future tracks correctly.

@rlaphoenix rlaphoenix added the bug Something isn't working label Mar 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant