Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

-l all flag should probably take all lang instead of take all tracks #93

Open
nxmiru opened this issue Apr 3, 2024 · 4 comments
Open
Labels
enhancement New feature or request

Comments

@nxmiru
Copy link

nxmiru commented Apr 3, 2024

Is your feature request related to a problem? Please describe.
When -l all is supplied, devine take all audio tracks

image

Describe the solution you'd like
devine should take only 1 track per lang

Describe alternatives you've considered

title.tracks.audio = title.tracks.by_language(
    title.tracks.audio,
    (list(set([t.language.to_alpha3() for t in title.tracks.audio])) if 'all' in lang else lang),
    per_language=1
)
@nxmiru nxmiru added the enhancement New feature or request label Apr 3, 2024
@Sp5rky
Copy link

Sp5rky commented Apr 3, 2024

This is my stupid work-around to grab the highest quality for each language available.

devine dl -l ab,aa,af,ak,sq,am,ar,an,hy,as,av,ae,ay,az,bm,ba,eu,be,bn,bi,bs,br,bg,my,ca,ch,ce,ny,zh,cu,cv,kw,co,cr,hr,cs,da,dv,nl,dz,en,eo,et,ee,fo,fj,fi,fr,fy,ff,gd,gl,lg,ka,de,el,kl,gn,gu,ht,ha,he,hz,hi,ho,hu,is,io,ig,id,ia,ie,iu,ik,ga,it,ja,jv,kn,kr,ks,kk,km,ki,rw,ky,kv,kg,ko,kj,ku,lo,la,lv,li,ln,lt,lu,lb,mk,mg,ms,ml,mt,gv,mi,mr,mh,mn,na,nv,nd,nr,ng,ne,no,nb,nn,ii,oc,oj,or,om,os,pi,ps,fa,pl,pt,pa,qu,ro,rm,rn,ru,se,sm,sg,sa,sc,sr,sn,sd,si,sk,sl,so,st,es,su,sw,ss,sv,tl,ty,tg,ta,tt,te,th,bo,ti,to,ts,tn,tr,tk,tw,ug,uk,ur,uz,ve,vi,vo,wa,cy,wo,xh,yi,yo,za,zu <service> <title>

@AlejandroMesa22
Copy link

Is your feature request related to a problem? Please describe. When -l all is supplied, devine take all audio tracks

image

Describe the solution you'd like devine should take only 1 track per lang

Describe alternatives you've considered

title.tracks.audio = title.tracks.by_language(
    title.tracks.audio,
    (list(set([t.language.to_alpha3() for t in title.tracks.audio])) if 'all' in lang else lang),
    per_language=1
)

Not related to your suggestion, but what is the name of the font you are using on your terminal?

@nxmiru
Copy link
Author

nxmiru commented Apr 6, 2024

Is your feature request related to a problem? Please describe. When -l all is supplied, devine take all audio tracks
image
Describe the solution you'd like devine should take only 1 track per lang
Describe alternatives you've considered

title.tracks.audio = title.tracks.by_language(
    title.tracks.audio,
    (list(set([t.language.to_alpha3() for t in title.tracks.audio])) if 'all' in lang else lang),
    per_language=1
)

Not related to your suggestion, but what is the name of the font you are using on your terminal?

Cascadia Code 👍

@AlejandroMesa22
Copy link

Is your feature request related to a problem? Please describe. When -l all is supplied, devine take all audio tracks
image
Describe the solution you'd like devine should take only 1 track per lang
Describe alternatives you've considered

title.tracks.audio = title.tracks.by_language(
    title.tracks.audio,
    (list(set([t.language.to_alpha3() for t in title.tracks.audio])) if 'all' in lang else lang),
    per_language=1
)

Not related to your suggestion, but what is the name of the font you are using on your terminal?

Cascadia Code 👍

I have it installed, but it doesn't look like yours. 🤔

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
3 participants