Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

C2D_DrawText line height inconsistency #46

Open
CyberYoshi64 opened this issue Nov 14, 2023 · 0 comments
Open

C2D_DrawText line height inconsistency #46

CyberYoshi64 opened this issue Nov 14, 2023 · 0 comments

Comments

@CyberYoshi64
Copy link

CyberYoshi64 commented Nov 14, 2023

https://github.com/devkitPro/citro2d/blob/master/source/text.c#L329-L341

I'm pretty sure the ceilf() can be omitted (as well as in C2D_TextGetDimensions to keep consistency) without consequences to allow the text to smoothly scale without the lines visibly jumping.

I've done it myself and not found any issues so far.

Here's a video of a homebrew dialog box I made to showcase this issue:
https://cdn.discordapp.com/attachments/329983699804487681/1173802183494479912/cyxlaunchtest1.mp4?ex=65654778&is=6552d278&hm=2c0363ae6136044a80455738b793045ad1128feeb11052a5a8a8c588708ef4fa&

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant