Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#590: Fix Asciidoc files in documentation causing errors #670

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

alfeilex
Copy link
Member

@alfeilex alfeilex commented Oct 1, 2024

Fixes: #590

The main error occured by a missing line break of |== in projects.adoc. It looks like it traverse until Licence.adoc.

Further some links were incorrectly set to other files. E.g link:setups.asciidoc instead of link:setups.adoc.

Finally some refactoring suggested by intellij was made, because = <title> main title should be before [toc]. There are some other adoc files that have that, but it is not critical error that is also not recognized by asciidoctor-maven-plugin

Copy link
Contributor

@jan-vcapgemini jan-vcapgemini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I've added a small suggestion.

documentation/LICENSE.adoc Outdated Show resolved Hide resolved
@alfeilex alfeilex marked this pull request as ready for review October 1, 2024 15:01
@coveralls
Copy link
Collaborator

coveralls commented Oct 1, 2024

Pull Request Test Coverage Report for Build 11129527867

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 66.509%

Totals Coverage Status
Change from base Build 11128929808: 0.0%
Covered Lines: 6126
Relevant Lines: 8868

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: 👀 In review
Development

Successfully merging this pull request may close these issues.

Documentation has AsciiDoc syntax errors
3 participants