#676: Fix typos in coding-conventions asciidoc #677
+17
−17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Pull Request Test Coverage Report for Build 11176737615Details
💛 - Coveralls |
jan-vcapgemini
requested changes
Oct 2, 2024
| @@ -146,10 +146,10 @@ Always use the logger to output messages and never use `System.out` or `System.e | |||
| When catching exceptions always ensure the following: | |||
|
|
|||
| * Never call `printStackTrace()` method on an exception | |||
| * Either log or wrap and re-throw the entire catched exception. | |||
| * Either log or wrap and re-throw the entire catch exception. | |||
There was a problem hiding this comment.
Should still be catched I think, as it is a catched exception.
| Be aware that the cause(s) of an exception is very valuable information. | ||
| If you loose such information by improper exception-handling you may be unable to properly analyse production problems what can cause severe issues. | ||
| ** If you wrap and re-throw an exception ensure that the catched exception is passed as cause to the newly created and thrown exception. | ||
| ** If you wrap and re-throw an exception ensure that the catch exception is passed as cause to the newly created and thrown exception. |
There was a problem hiding this comment.
Should still be catched I think, as it is a catched exception.
| @@ -170,7 +170,7 @@ Exception in thread "main" java.lang.IllegalStateException: Something failed | |||
| at com.devonfw.tools.ide.ExceptionHandling.main(ExceptionHandling.java:14) | |||
| ---- | |||
|
|
|||
| As you can see we have no information and clue what the catched `Exception` was and what really went wrong in `doSomething()`. | |||
| As you can see we have no information and clue what the catch `Exception` was and what really went wrong in `doSomething()`. | |||
There was a problem hiding this comment.
Should still be catched I think, as it is a catched exception.
Co-authored-by: jan-vcapgemini <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #676