Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to Spring Kafkas retry implementation #459

Open
1 of 5 tasks
maihacke opened this issue Sep 28, 2021 · 0 comments
Open
1 of 5 tasks

Switch to Spring Kafkas retry implementation #459

maihacke opened this issue Sep 28, 2021 · 0 comments
Assignees
Labels
enhancement New feature or request kafka

Comments

@maihacke
Copy link
Member

maihacke commented Sep 28, 2021

Devon4Js Kafka module provides a retry implementation which leverages additional retry queues to offer a non blocking retry.
In the meantime Spring Kafkas library provides a very similar implementation.
I suggest dropping our own implementation and recommend using the "native" Spring implementation.
New projects should use this even if is currently in an experimental state (expected API changes, but considered "robust" and "feature complete").

So we should:

  • Deprecate our own retry implementation
  • Upgrade Spring Kafka to a newer version (> 2.7.0 which introduced this feature)
  • Check carefully if other features (e.g. span injection, logging, ...) are still necessary in Devon4J-Kafka module or also have been superseeded by Spring
  • Update Devon4Js Kafka module docs
  • Update Kafak sample application (https://github.com/devonfw-sample/devon4j-kafka-employeeapp)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request kafka
Projects
None yet
Development

No branches or pull requests

4 participants