Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

API changes #34

Open
mziegler opened this issue Oct 19, 2017 · 0 comments
Open

API changes #34

mziegler opened this issue Oct 19, 2017 · 0 comments

Comments

@mziegler
Copy link
Member

  1. Maybe this is just an issue related to the difference between the API that the frontend needs and what an user might want to download via the download button, but I think we need to include the blacklisted SRA keys in the outputs. It should be easy to include these in the CSV, I think. The JSON is trickier because the frontend uses the sample groupings, which is dependent on the blacklisted keys. But you might be able to include these as additional lists in the JSON (i.e., for each blacklisted key, have a list of the values, which all lists being the same order, such that one could recreate the original raw metadata, if one needed to).

  2. In the “Terms” result, can you report the “radius” used.

  3. For reproducibility, it would be good to report the database version (and any other relevant parameters) in the JSON output.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant