-
Notifications
You must be signed in to change notification settings - Fork 82
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sidecar containers support #9
Comments
I would put a hold on this until we have a strong operational use case that we can't solve otherwise (eg. a database or even a gRPC adapter can certainly be a separate service, there is no strong reason to keep that inside of the Dex boundary) |
In my opinion, the main reason people may want to use a sidecar container is to protect dex. For example:
With this, other pods can't interact with dex bypassing authorization. I do something like this in my helm-charts, though they are very opinionated. Of course, you can use network policies or service mash, or whatever instead. So, I have no objections to wait and let users decide about the value of this feature. |
Not specifically a sidecar, but my use-case is to inject the LDAP connector BINDPW via Vault agent. So ideally being able to specify a different For now I've just copied this helm chart and added the corresponding |
@saamalik I'd suggest using a mutating webhook for that. |
Would be nice to support an initContainer to allow for custom template/style with out having to maintain a custom image. We'd previously used an initContainer to unzip our styling ( from a config map ) into a volume that was mounted onto the dex pod.. The feature was available here previously ( old helm2 pile-o-charts repo...) : |
IMHO a custom built image is much safer, because there are less moving parts at runtime. |
Description
I propose to consider adding the
containers
section. This section will allow users to inject additional containers, e.g., a reverse proxy, GRPC API adapter, or even a database.values.yaml
Additional info
Adding the
initContainers
section can also be useful for preparing config, certificates, or other assets.The text was updated successfully, but these errors were encountered: