Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvement: {bslib} (-ify) the UI #14

Open
JT-39 opened this issue Sep 9, 2024 · 1 comment · Fixed by #15
Open

Improvement: {bslib} (-ify) the UI #14

JT-39 opened this issue Sep 9, 2024 · 1 comment · Fixed by #15

Comments

@JT-39
Copy link
Contributor

JT-39 commented Sep 9, 2024

Improvement Overview

{bslib} is the new gold standard for shiny dashboard applications. The package provides a modern UI toolkit for Shiny and R Markdown based on Bootstrap. Previous UI packages such as {shinydashboard} are being depreciated and so should be moved away from.

The DfE shiny-template currently uses some of the older UI functions such as shiny::fluidPage() and shinyWidgets::useShinydashboard(). This needs to be refactored to use the equivalent {bslib} functions where possible. There are other major benefits to doing this other than moving away from depreciated code, such as improvements in accessibility (due to the fillable feature in the UI functions) and improved customisation through easier css and access to the Bootstrap and Bootswatch functionalities.

Current Issue

The DfE shiny-template uses legacy shiny UI code, such as shiny::fluidPage() and shinyWidgets::useShinydashboard().

Proposed Enhancement

To replace and upgrade this code with the equivalent (or best) {bslib} functions, such as bslib::page_fillable().

Impact

This must result in the same functionality. There should be benefit from improved accessibility (due to the fillable feature of {bslib} UI functions) and a smoother/ more aesthetic overall UI experience.

Additional Information

This will likely be an iterative process and should also try to be extracted so that it can be contributed to the DfE shiny-template

@JT-39 JT-39 mentioned this issue Sep 9, 2024
4 tasks
@JT-39 JT-39 linked a pull request Sep 9, 2024 that will close this issue
4 tasks
@JT-39 JT-39 closed this as completed in #15 Sep 9, 2024
@JT-39 JT-39 reopened this Sep 9, 2024
@JT-39
Copy link
Contributor Author

JT-39 commented Sep 9, 2024

Re-opening for the reason's given in the Additional Information of this issue and the Bslib ify shiny template pull request

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant