Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvement: New dfeshiny functionality - custom_disconnect_message and cookies_banner_server #69

Open
2 tasks
JT-39 opened this issue Dec 24, 2024 · 0 comments

Comments

@JT-39
Copy link
Contributor

JT-39 commented Dec 24, 2024

Improvement Overview

{dfeshiny} has had an update and a few functions have some additional functionality which are of use.

Current Issue

Currently I have a temporary function cookies_banner_server_jt() which allows the specification of the navigation panel id (in my case this is "pages"). The dfeshiny::cookies_banner_server() was strict and did not permit for this id to be different to the default "navlistPanel". However, now this has been relaxed. So the dfeshiny::cookies_banner_server() can be used.

Also, the dfeshiny::custom_disconnect_message() has been updated to allow for extra email addresses to be included (for example [email protected]) and an extra link to be available for refresh (for example, the default https://department-for-education.shinyapps.io/local-authority-interactive-tool/ - which has no bookmarking).

Proposed Enhancement

Impact

Tidier code and inline with the {dfeshiny} package. Better disconnect button.

Additional Information

Currently waiting on a couple changes to {dfeshiny} to do these updates:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

When branches are created from issues, their pull requests are automatically linked.

1 participant