-
-
Notifications
You must be signed in to change notification settings - Fork 163
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use Ring Ice Servers #1282
Comments
Ha, funny, I had noticed this when I was digging and noted it for further research, but at the time I was just focused on getting the code to work at all (at the time I was still tracking the immediate socket disconnect issue). I'll fire up the app with mitmproxy and take a look sometime later tonight or tomorrow. |
Nice, glad it was on your radar already 😄. Probably not a huge deal if we don't figure it out as the existing stun servers seem to work in most scenarios. I'm guessing we end up using the ice candidates provided by the websocket connection (as part of the webrtc answer) all the time anyways, so it might not really make a difference. Just nice to match with Ring as much as possible to avoid future issues. |
Yes, that's exactly correct, the trickle ice methods implemented as part of the websocket seem to work pretty well, however, as you noted, the TURN service might explain why there are cases where the web playback will work while werift couldn't seem to make a connection. Although, admittedly, this may also be because werift appears not to support TCP candidates, which the browser will fall back to pretty quickly. If I block all UDP for my firewall, Ring playback via the browser will still work via TCP 443 since that is one of the passed candidates, but werift will not work with this as far as I can tell, at least I've never been able to get it to work. A TURN server probably won't help this case, but it might help double NAT or other weird cases. |
Description
While looking at the new webrtc api, I noticed that the Ring web app seems to be fetching a set of ice servers when you first load the page. These values are then stored in
localStorage
underwrtc-isc
(base64 encoded) and not fetched again.The request is something like this:
GET https://account.ring.com/api/cmds/iceConfig
With a response like this: (note i've redacted the creds in case they are personal)
We currently use a set of hard-coded STUN servers to gather ice candidates, but it would be much preferred to use these servers provided by Ring. The fact that there are turn servers in here means we may get some much better connection options for complex network scenarios (eg users on VPNs).
The biggest challenge is that the url from the web app (
https://account.ring.com/api/cmds/iceConfig
) does not directly translate to the url we need to use from Node.js. We need to figure out the right URL, and then it should be easy to start using the provided servers.@tsightler maybe you have some insight here? Are the android/ios apps making similar calls to a different endpoint by chance?
The text was updated successfully, but these errors were encountered: