New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactoring .after(Predicate<X> prd, long size) #61

Open

dgroup opened this issue May 8, 2021 · 1 comment

Labels

good first issue

Owner

dgroup commented May 8, 2021 •

edited

Loading

Actual result:

default Enumerable<X> after(Predicate<X> prd, long size) {
    final Enumerable<X> out;
    if (size < 0) {
        throw new IllegalArgumentException(Long.toString(size));
    } else if (size == 0) {
        out = new Empty<>();
    } else if (prd == null) {
        out = new Linked<>(this.stream().limit(size).collect(Collectors.toList()));
    } else {
        ...

Expected result:

default Enumerable<X> after(Predicate<X> prd, long size) {
    final Enumerable<X> out;
    if (size < 0) {
        throw new IllegalArgumentException(Long.toString(size));
    } else if (size == 0 || prd == null) {
        out = new Empty<>();
    } else {
       ...

dgroup changed the title ~~Refactoring~~ Refactoring after(Predicate<X> prd, long size)

dgroup added the good first issue label

dgroup changed the title ~~Refactoring after(Predicate<X> prd, long size)~~ Refactoring .after(Predicate<X> prd, long size)

Contributor

dykov commented May 10, 2021

Done in #62
@dgroup , plese close the issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment