You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
At the moment we have forked proto3-wire, proto3-suite, grpc-haskell-core and grpc-haskell. We should aim to unfork them all, since we're treading much the same path the upstream is treading.
The text was updated successfully, but these errors were encountered:
First step is moving to new versions of proto3-wire and proto3-suite. Turns out that the generation changes are incompatible with the fork we have (you get a test failure), so we need to move to both simultaneously.
Francesco did a lot of performance work on the proto3-wire. Separately, upstream (specifically @gbaz) also did a lot of performance work. Comparing on the test of writing out the LF for the CDM spec, our version took 5.4s, while upstream to 4.0s. I've raised a ticket for upstream to see if they want any of our tweaks awakesecurity/proto3-wire#50, and merged some obvious ones awakesecurity/proto3-suite#95. I also audited the changes, finding something at least with dodgy comments: awakesecurity/proto3-wire#51
When I actually try and move I ran into an issue with proto3-suite generating invalid code. I've raised that upstream awakesecurity/proto3-suite#97 and will work to get that resolved upstream at some point.
At the moment we have forked proto3-wire, proto3-suite, grpc-haskell-core and grpc-haskell. We should aim to unfork them all, since we're treading much the same path the upstream is treading.
The text was updated successfully, but these errors were encountered: