Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move to upstream versions of Haskell grpc libraries #501

Closed
neil-da opened this issue Apr 15, 2019 · 3 comments
Closed

Move to upstream versions of Haskell grpc libraries #501

neil-da opened this issue Apr 15, 2019 · 3 comments
Assignees

Comments

@neil-da
Copy link
Contributor

neil-da commented Apr 15, 2019

At the moment we have forked proto3-wire, proto3-suite, grpc-haskell-core and grpc-haskell. We should aim to unfork them all, since we're treading much the same path the upstream is treading.

@neil-da neil-da self-assigned this Apr 15, 2019
@neil-da
Copy link
Contributor Author

neil-da commented Apr 17, 2019

First step is moving to new versions of proto3-wire and proto3-suite. Turns out that the generation changes are incompatible with the fork we have (you get a test failure), so we need to move to both simultaneously.

Francesco did a lot of performance work on the proto3-wire. Separately, upstream (specifically @gbaz) also did a lot of performance work. Comparing on the test of writing out the LF for the CDM spec, our version took 5.4s, while upstream to 4.0s. I've raised a ticket for upstream to see if they want any of our tweaks awakesecurity/proto3-wire#50, and merged some obvious ones awakesecurity/proto3-suite#95. I also audited the changes, finding something at least with dodgy comments: awakesecurity/proto3-wire#51

Neil did some work on Windows fixes and I've upstreamed those awakesecurity/proto3-suite#94.

When I actually try and move I ran into an issue with proto3-suite generating invalid code. I've raised that upstream awakesecurity/proto3-suite#97 and will work to get that resolved upstream at some point.

@neil-da
Copy link
Contributor Author

neil-da commented Apr 17, 2019

I patched the generation of invalid code in awakesecurity/proto3-suite#99. The other change stopping us moving was that proto3-suite doesn't generate NFData instances. I've fixed both of those issues in https://github.com/ndmitchell/proto3-suite/tree/nfdata

@cocreature
Copy link
Contributor

we’re more or less on the upstream versions now so closing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants