Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

did:web support #9

Closed
stuartf opened this issue Aug 21, 2023 · 10 comments
Closed

did:web support #9

stuartf opened this issue Aug 21, 2023 · 10 comments
Assignees

Comments

@stuartf
Copy link

stuartf commented Aug 21, 2023

I'd like to get this to feature parity with cred-admin and consolidate work here. I think the lowest hanging fruit is probably did:web support.

Any pointers on where to start, or thoughts about how to implement before I just dive in are appreciated.

@dmitrizagidulin
Copy link
Member

@stuartf - Thanks!
So, this repo (issuer-coordinator) itself does not deal with DIDs, it's just a coordinator that uses HTTP API calls to other services.

The code that deals with creating an IssuerInstance (with the signer function that is used to issue VCs) lives here: https://github.com/digitalcredentials/signing-service/blob/7169709b15d7f6976e702b97546a961f6f19a97e/src/issue.js#L10

So what you'll probably need to do is add another config value, something like issuerDidMethod (which would hold key or web). And then depending on the type, generate either a did:key from seed (which it already does), or generate a did:web, and in either case, create a signingSuite and proceed as normal.

Let me know if that helps (@jchartrand - jump in if I'm off base here)

@kayaelle
Copy link
Member

@dmitrizagidulin
Copy link
Member

@kayaelle sure, that seems reasonable.

@stuartf
Copy link
Author

stuartf commented Sep 13, 2023

@dmitrizagidulin any advice on getting a did-io driver for did:web? It looks like the did:key driver we're using (https://github.com/digitalcredentials/did-method-key) was forked from https://github.com/digitalbazaar/did-method-key but we don't have a https://github.com/digitalcredentials/did-method-web and https://github.com/digitalbazaar/did-method-web looks like it has a PR open to make it functional but also hasn't been updated in almost a year.

@dmitrizagidulin
Copy link
Member

@dmitrizagidulin any advice on getting a did-io driver for did:web? It looks like the did:key driver we're using (https://github.com/digitalcredentials/did-method-key) was forked from https://github.com/digitalbazaar/did-method-key but we don't have a https://github.com/digitalcredentials/did-method-web and https://github.com/digitalbazaar/did-method-web looks like it has a PR open to make it functional but also hasn't been updated in almost a year.

Much apologies for the delay. There is a did-io driver for did:web here: https://github.com/interop-alliance/did-web-resolver

I'd love to hop on a call and walk you through some of the details we'll need to change for issuer-coordinator, to support this.

@stuartf
Copy link
Author

stuartf commented Oct 27, 2023

Great, I'll take a look at @interop/did-web-resolver

I'm free Monday or Tuesday afternoons next week if you want to do a call then.

@kayaelle
Copy link
Member

kayaelle commented Nov 1, 2023

Hey @stuartf & @dmitrizagidulin - how's this going?

@stuartf
Copy link
Author

stuartf commented Nov 1, 2023

Hi @kayaelle I haven't had much time to dig into @interop/did-web-resolver hoping to get more into it before the end of the week.

@kayaelle kayaelle assigned stuartf and unassigned dmitrizagidulin Nov 15, 2023
@kayaelle
Copy link
Member

kayaelle commented Jan 31, 2024

Testing by @jchartrand w/micro-services in progress

@alexfigtree
Copy link
Member

James says this can be closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done (Deployed)
Development

No branches or pull requests

4 participants