Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Find alternative for time.sleep in link replacement function #3004

Open
MizukiTemma opened this issue Aug 16, 2024 · 1 comment
Open

Find alternative for time.sleep in link replacement function #3004

MizukiTemma opened this issue Aug 16, 2024 · 1 comment
Labels
🔨 enhancement This improves an existing feature 📣 needs-internal-discussion Us developers need to discuss first which way of implementation is considered to be the best

Comments

@MizukiTemma
Copy link
Member

MizukiTemma commented Aug 16, 2024 •
edited
Loading

Motivation

Currently we use time.sleep in replace_links and LinkcheckListView to wait the link replacement procedure to be finished. However this is not so reliable and causes unnecessary waiting time.

Proposed Solution

Find an alternative way to ensure the link replacement procedure is completed without causing unnecessary waiting time.

Alternatives

Leave it as it is.

User Story

Additional Context

See this comment for more context.

Design Requirements
@MizukiTemma MizukiTemma added 💡 feature New feature or request 📣 needs-internal-discussion Us developers need to discuss first which way of implementation is considered to be the best 🔨 enhancement This improves an existing feature and removed 💡 feature New feature or request labels Aug 16, 2024
@timobrembeck
Copy link
Member

I'm pretty sure that this issue can only be fixed by corresponding changes to the linkcheck library.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
🔨 enhancement This improves an existing feature 📣 needs-internal-discussion Us developers need to discuss first which way of implementation is considered to be the best
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@timobrembeck @MizukiTemma