Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deadlock if Stream Shutdown races with Push #191

Open
multippt opened this issue Apr 13, 2023 · 0 comments · May be fixed by #190
Open

Deadlock if Stream Shutdown races with Push #191

multippt opened this issue Apr 13, 2023 · 0 comments · May be fixed by #190

Comments

@multippt
Copy link

There's a deadlock scenario if the stream is being shutdown while still receiving events, which can occur if using LifecycleEvents and cancelling the context.

Example reproduction case

func TestStreamShutdown(t *testing.T) {
	s := NewStream(1, 2)
	events := testEvents(1)
	s.Shutdown()
	s.Push(events[0])
}
@multippt multippt linked a pull request Apr 13, 2023 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant