Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Count the actual number of http requests to NetBox instead of retried requests #13

Open
d-honeybadger opened this issue Jun 30, 2022 · 0 comments
Open

Count the actual number of http requests to NetBox instead of retried requests #13

d-honeybadger opened this issue Jun 30, 2022 · 0 comments

Comments

@d-honeybadger
Copy link
Contributor

Since http requests to NetBox use an http client with retries, the actual number of http requests can be bigger than the number of client.Do() invocations. This is relevant for

  • rate-limiting
  • metrics collection

Instead of on every httpClient.Do(), waiting (for rate-limiting) and incrementing total number of requests should happen in RequestLogHook.
ztariq21 pushed a commit that referenced this issue Jul 31, 2023
@NickDombroski
Merge pull request #13 from digitalocean/ndombroski/DELI-3901
45ff474 
DELI-3901: Add netbox-ca-cert-path flag
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@d-honeybadger