Databases: Set Kafka Connection Attributes (port, uri, private_uri) #1131
Conversation
| // default for kafka will be Public SASL port, consistent with UI | ||
| d.Set("port", kafkaPublicSSLPort) |
There was a problem hiding this comment.
Are the ports guaranteed to be stable? Maybe we should grab it from the response? Something like:
const kafkaSASL = "sasl"
if database.Connection.ApplicationPorts != nil {
if saslPort, ok := database.Connection.ApplicationPorts[kafkaSASL]; ok {
d.Set("port", saslPort)
}
}| func buildKafkaConnectionURI(conn *godo.DatabaseConnection, port int) string { | ||
| host := conn.Host | ||
|
|
||
| uri := fmt.Sprintf("%s:%d", host, port) |
There was a problem hiding this comment.
Lets make sure that this is consistent with what the DBaaS team will eventually return from the API. Should there be a scheme? The other engines all seem to use the format scheme://user:pass@host:port
There was a problem hiding this comment.
Lets make sure that this is consistent with what the DBaaS team will eventually return from the API. Should there be a scheme? The other engines all seem to use the format
scheme://user:pass@host:port
Converting this PR to a draft as dbaas said they might actually get to it this week or next!
|
Thanks for the implementation! |
Addresses #1121
Database team is working on a ticket to address this in the API layer, but in the meantime this sets the port, uri, and private uri at the terraform layer so users can easily collect connection details for their kafka clusters.
Default port will be the public SASL port, 25073. This is consistent with the UI.