Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable failing linter: errcheck #1227

Closed
loosla opened this issue Sep 24, 2024 · 4 comments
Closed

Enable failing linter: errcheck #1227

loosla opened this issue Sep 24, 2024 · 4 comments

Comments

@loosla
Copy link
Contributor

loosla commented Sep 24, 2024

Some linters are disabled.
Please enable the failing errcheck linter and make the necessary changes to ensure that the checks pass.

Steps:

  1. Uncomment errcheck in
  2. Run make lint from the root directory of the repo to see the issues to fix
  3. Fix the issues to make make lint pass
@TheMarvelFan
Copy link
Contributor

Hi,

Iis anyone working on this issue?
I would like to take it up if no one is.

Thanks.

@loosla
Copy link
Contributor Author

loosla commented Sep 30, 2024

Hey @TheMarvelFan,
While there aren't any existing PRs for this issue, it would be fantastic if you could create one!
To link your PR to the issue, just include keywords like closes #1227 in the description. You can find more details here: https://docs.github.com/en/issues/tracking-your-work-with-issues/using-issues/linking-a-pull-request-to-an-issue#linking-a-pull-request-to-an-issue-using-a-keyword.
Thanks for contributing—we can’t wait to see your PR!

@TheMarvelFan
Copy link
Contributor

TheMarvelFan commented Oct 1, 2024

Hi @loosla ,

I have created the PR to fix this issue. Please review the changes and let me know if any further modifications are required.

Thanks!

@TheMarvelFan
Copy link
Contributor

TheMarvelFan commented Oct 1, 2024

@loosla

Also before merging the PR, I request you to assign this issue to me, as well as change the label on this issue from 'hacktoberfest' (with a small 'h') to 'Hacktoberfest' (with a capital 'H'), as the Hacktoberfest website is only detecting issues labeled with 'Hacktoberfest'.

Hope this is understandable.

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants