Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HamiltonianPath checks for Hamiltonian cycles #545

Open
TomGoertzen opened this issue May 4, 2022 · 2 comments
Open

HamiltonianPath checks for Hamiltonian cycles #545

TomGoertzen opened this issue May 4, 2022 · 2 comments
Labels
bug A label for issues that are bugs not-backwards-compatible A label for PRs that break backwards compatibility

Comments

@TomGoertzen
Copy link

The function HamiltonianPath computes hamiltonian cycles which is a bit confusing if someone looks for paths and not cycles. A name change to HamiltonianCycle perhaps would be nice.
@james-d-mitchell
Copy link
Member

Thanks @TomGoertzen for the report, that's an excellent point, we will rename HamiltonianPath to HamiltonianCycle in the next major release of Digraphs.

@james-d-mitchell james-d-mitchell changed the title HamiltonianPath checks for Hamiltonian Cycles HamiltonianPath checks for Hamiltonian cycles May 20, 2022
@james-d-mitchell james-d-mitchell added bug A label for issues that are bugs not-backwards-compatible A label for PRs that break backwards compatibility labels May 20, 2022
@github-actions
Copy link

Stale issue message

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug A label for issues that are bugs not-backwards-compatible A label for PRs that break backwards compatibility
Projects
TODO for next major release (breaking changes)
Status: Todo
Milestone
No milestone
Development

No branches or pull requests
2 participants
@james-d-mitchell @TomGoertzen