Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CI failing for 32-bit #587

Closed
mtorpey opened this issue May 17, 2023 · 11 comments
Closed

CI failing for 32-bit #587

mtorpey opened this issue May 17, 2023 · 11 comments
Labels
C language A label for issues or pull requests relating to the kernel module of the package ci Issues/PRs related to continuous integration (Azure Pipelines, GitHub Actions, AppVeyor, Codecov)

Comments

@mtorpey
Copy link
Collaborator

mtorpey commented May 17, 2023

As shown at:
https://github.com/digraphs/Digraphs/actions/runs/4806182761/jobs/8963120783

To start with I thought this was my PR, but when I rerun the main branch it's doing it too. Probably a bug in the tests or in GAP?
@james-d-mitchell
Copy link
Member

I'm not sure if GAP didn't stop supporting 32 bit builds, maybe I'm misremembering. If 32 bit is no longer needed, then we can just drop this CI job. Alternatively, it'd probably suffice to increase the version of ubuntu used in the CI job, which might resolve the issue too. Writing in a hurry, maybe completely wrong...

@mtorpey
Copy link
Collaborator Author

mtorpey commented May 18, 2023

Looks like it fails on all GAP branches: master, stable-4.12 and stable-4.11. So I guess it's not that GAP has dropped it.

https://github.com/digraphs/Digraphs/actions/runs/5012528703/jobs/8984579183

@mtorpey
Copy link
Collaborator Author

mtorpey commented May 18, 2023

Ubuntu 23.04 (Lunar Lobster) released a month ago, and our tests are pointed at ubuntu-latest. That could be the source of the problem.

@mtorpey
Copy link
Collaborator Author

mtorpey commented May 18, 2023

Nope, looks like the tests are using Ubuntu jammy, so no change there. The issue is on installation:

Installing dependencies
Hit:1 http://azure.archive.ubuntu.com/ubuntu jammy InRelease
Get:2 http://azure.archive.ubuntu.com/ubuntu jammy-updates InRelease [119 kB]
Get:3 http://azure.archive.ubuntu.com/ubuntu jammy-backports InRelease [108 kB]
Get:4 http://azure.archive.ubuntu.com/ubuntu jammy-security InRelease [110 kB]
Get:5 https://packages.microsoft.com/ubuntu/22.04/prod jammy InRelease [3611 B]
Get:6 http://azure.archive.ubuntu.com/ubuntu jammy/main i386 Packages [1040 kB]
Get:7 http://azure.archive.ubuntu.com/ubuntu jammy/restricted i386 Packages [30.4 kB]
Get:8 http://azure.archive.ubuntu.com/ubuntu jammy/universe i386 Packages [7474 kB]
Get:9 http://azure.archive.ubuntu.com/ubuntu jammy/multiverse i386 Packages [112 kB]
Get:10 http://azure.archive.ubuntu.com/ubuntu jammy-updates/main i386 Packages [395 kB]
Get:11 http://azure.archive.ubuntu.com/ubuntu jammy-updates/main amd64 Packages [604 kB]
Get:12 http://azure.archive.ubuntu.com/ubuntu jammy-updates/main Translation-en [170 kB]
Get:13 http://azure.archive.ubuntu.com/ubuntu jammy-updates/main amd64 c-n-f Metadata [14.4 kB]
Get:14 http://azure.archive.ubuntu.com/ubuntu jammy-updates/restricted amd64 Packages [271 kB]
Get:15 http://azure.archive.ubuntu.com/ubuntu jammy-updates/restricted i386 Packages [28.3 kB]
Get:16 http://azure.archive.ubuntu.com/ubuntu jammy-updates/restricted Translation-en [41.3 kB]
Get:17 http://azure.archive.ubuntu.com/ubuntu jammy-updates/universe amd64 Packages [899 kB]
Get:18 http://azure.archive.ubuntu.com/ubuntu jammy-updates/universe i386 Packages [610 kB]
Get:19 http://azure.archive.ubuntu.com/ubuntu jammy-updates/universe Translation-en [185 kB]
Get:20 http://azure.archive.ubuntu.com/ubuntu jammy-updates/universe amd64 c-n-f Metadata [18.8 kB]
Get:21 http://azure.archive.ubuntu.com/ubuntu jammy-updates/multiverse amd64 Packages [35.3 kB]
Get:22 http://azure.archive.ubuntu.com/ubuntu jammy-updates/multiverse i386 Packages [3884 B]
Get:23 http://azure.archive.ubuntu.com/ubuntu jammy-updates/multiverse Translation-en [8452 B]
Get:24 http://azure.archive.ubuntu.com/ubuntu jammy-backports/main i386 Packages [33.7 kB]
Get:25 http://azure.archive.ubuntu.com/ubuntu jammy-backports/universe i386 Packages [12.7 kB]
Get:26 http://azure.archive.ubuntu.com/ubuntu jammy-security/main i386 Packages [215 kB]
Get:27 http://azure.archive.ubuntu.com/ubuntu jammy-security/main amd64 Packages [388 kB]
Get:28 http://azure.archive.ubuntu.com/ubuntu jammy-security/main Translation-en [111 kB]
Get:29 http://azure.archive.ubuntu.com/ubuntu jammy-security/main amd64 c-n-f Metadata [9744 B]
Get:30 https://ppa.launchpadcontent.net/ubuntu-toolchain-r/test/ubuntu jammy InRelease [23.8 kB]
Get:31 http://azure.archive.ubuntu.com/ubuntu jammy-security/restricted amd64 Packages [270 kB]
Get:32 http://azure.archive.ubuntu.com/ubuntu jammy-security/restricted i386 Packages [28.0 kB]
Get:33 http://azure.archive.ubuntu.com/ubuntu jammy-security/restricted Translation-en [41.0 kB]
Get:34 https://packages.microsoft.com/ubuntu/22.04/prod jammy/main all Packages [904 B]
Get:35 https://packages.microsoft.com/ubuntu/22.04/prod jammy/main armhf Packages [7155 B]
Get:36 https://packages.microsoft.com/ubuntu/22.04/prod jammy/main arm64 Packages [13.7 kB]
Get:37 https://packages.microsoft.com/ubuntu/22.04/prod jammy/main amd64 Packages [64.5 kB]
Get:38 http://azure.archive.ubuntu.com/ubuntu jammy-security/universe i386 Packages [526 kB]
Get:39 http://azure.archive.ubuntu.com/ubuntu jammy-security/universe amd64 Packages [722 kB]
Get:40 http://azure.archive.ubuntu.com/ubuntu jammy-security/universe Translation-en [125 kB]
Get:41 http://azure.archive.ubuntu.com/ubuntu jammy-security/universe amd64 c-n-f Metadata [14.4 kB]
Get:42 http://azure.archive.ubuntu.com/ubuntu jammy-security/multiverse amd64 Packages [30.2 kB]
Get:43 http://azure.archive.ubuntu.com/ubuntu jammy-security/multiverse i386 Packages [1028 B]
Get:44 http://azure.archive.ubuntu.com/ubuntu jammy-security/multiverse Translation-en [5828 B]
Get:45 https://ppa.launchpadcontent.net/ubuntu-toolchain-r/test/ubuntu jammy/main i386 Packages [2124 B]
Get:46 https://ppa.launchpadcontent.net/ubuntu-toolchain-r/test/ubuntu jammy/main amd64 Packages [15.7 kB]
Get:47 https://ppa.launchpadcontent.net/ubuntu-toolchain-r/test/ubuntu jammy/main Translation-en [7292 B]
Fetched 15.0 MB in 2s (6535 kB/s)
Reading package lists...
Reading package lists...
Building dependency tree...
Reading state information...
Some packages could not be installed. This may mean that you have
requested an impossible situation or if you are using the unstable
distribution that some required packages have not yet been created
or been moved out of Incoming.
The following information may help to resolve the situation:

The following packages have unmet dependencies:
 libc6:i386 : Depends: libgcc-s1:i386 but it is not going to be installed
 libgmpxx4ldbl:i386 : Depends: libgcc-s1:i386 (>= 3.0) but it is not going to be installed
                      Depends: libstdc++6:i386 (>= 5.2) but it is not going to be installed
E: Unable to correct problems, you have held broken packages.
Error: Process completed with exit code 100.

I think this comes from setup-gap/action.yml: https://github.com/gap-actions/setup-gap/blob/44a8ae68e262dd0d22b84ef146460741b4c06c70/action.yml#L37C1-L66

Some funny business with dependencies.

@mtorpey
Copy link
Collaborator Author

mtorpey commented May 18, 2023

Raised at gap-actions/setup-gap#45

@wilfwilson
Copy link
Collaborator

I'll just mention to remind us that Digraphs has some 32-bit specific code, so if and when we stop testing on 32-bit, I'd recommend dropping our 32-bit support and ripping out that code.

@james-d-mitchell
Copy link
Member

Good point @wilfwilson, a super satisfying deletion of code will follow :)

@james-d-mitchell james-d-mitchell added the ci Issues/PRs related to continuous integration (Azure Pipelines, GitHub Actions, AppVeyor, Codecov) label May 19, 2023
@james-d-mitchell
Copy link
Member

My reading of @fingolfin's last comment on:

gap-actions/setup-gap#45

is that 32-bit continuous integration for GAP is not currently feasible (or at least not worth the effort). I tend to agree, I don't think this is the same as dropping support for 32-bit though, I'd suggest we retain 32-bit support until either:

  • it is found to be hopelessly broken, or
  • GAP stops supporting 32-bit officially,

At that point we can drop support for 32-bit, and remove any relevant special code. What do @mtorpey and @wilfwilson say?

@james-d-mitchell james-d-mitchell added the C language A label for issues or pull requests relating to the kernel module of the package label Jan 10, 2024
@james-d-mitchell james-d-mitchell changed the title CI failing on all branches for "ubuntu32 / GAP master" CI failing for 32-bit Jan 10, 2024
@mtorpey
Copy link
Collaborator Author

mtorpey commented Jan 10, 2024

I agree! We can leave our code in there in case it's useful to someone.

However, to resolve this issue: should we drop 32-bit from our test suite?

@james-d-mitchell
Copy link
Member

Thanks @mtorpey: yes, let's drop 32-bit from the test suite.

I'll make a new issue about 32-bit support.

@james-d-mitchell james-d-mitchell mentioned this issue Jan 10, 2024
Open
@mtorpey
Copy link
Collaborator Author

mtorpey commented Jan 10, 2024

This is superseded by #602.

@mtorpey mtorpey closed this as completed Jan 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
C language A label for issues or pull requests relating to the kernel module of the package ci Issues/PRs related to continuous integration (Azure Pipelines, GitHub Actions, AppVeyor, Codecov)
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@mtorpey @james-d-mitchell @wilfwilson