Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor results processor to only have decision logic #19

Open
dills122 opened this issue May 31, 2019 · 0 comments
Open

Refactor results processor to only have decision logic #19

dills122 opened this issue May 31, 2019 · 0 comments
Labels
enhancement New feature or request

Comments

@dills122
Copy link
Owner

Refactor the process-results.js file to remove all of the hashing logic and move it to separate class.

Refactor the decision logic to more accurate hash matching.

Create a better way of checking if the card hash already exists in the db instead of waiting till the insert method is called.

process-results.js
card-hash.js
@dills122 dills122 added the enhancement New feature or request label May 31, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@dills122