Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow usage of custom .cargo/config.toml options #49

Open
Suyashtnt opened this issue Jun 30, 2022 · 2 comments
Open

Allow usage of custom .cargo/config.toml options #49

Suyashtnt opened this issue Jun 30, 2022 · 2 comments
Labels
enhancement New feature or request in-progress Managed by Dimension medium-priority Managed by Dimension

Comments

@Suyashtnt
Copy link

Is your feature request related to a problem? Please describe.
I am attempting to use this with a project that uses simdjson, which requires me to edit the config.toml file with extra options (specifically setting target-cpu=native)

Describe the solution you'd like
The ability to specify extra config.toml options in fleet.toml

Describe alternatives you've considered
None

Additional context
Error from simdjson

error[E0308]: mismatched types
   --> /home/tntman/.cargo/registry/src/github.com-1ecc6299db9ec823/simd-json-0.4.15/src/lib.rs:222:86
    |
222 | fn please_compile_with_a_simd_compatible_cpu_setting_read_the_simdjsonrs_readme() -> ! {}
    |    ----------------------------------------------------------------------------      ^ expected `!`, found `()`
    |    |
    |    implicitly returns `()` as its body has no tail or `return` expression
    |
    = note:   expected type `!`
            found unit type `()`

config values I need:
https://github.com/simd-lite/simd-json/blob/main/.cargo/config#L1-L2

@Suyashtnt Suyashtnt added the enhancement New feature or request label Jun 30, 2022
@VarunPotti
Copy link
Contributor

Will look into implementing this soon.

@suptejas suptejas added medium-priority Managed by Dimension in-progress Managed by Dimension labels May 29, 2023 — with Dimension App
@suptejas suptejas removed medium-priority Managed by Dimension in-progress Managed by Dimension labels May 31, 2023
@dimensionhq dimensionhq deleted a comment from faisalsayed10 May 31, 2023
@dimensionhq dimensionhq deleted a comment from reecepm Jun 4, 2023
@dimensionhq dimensionhq deleted a comment from haaarshsingh Jun 4, 2023
@suptejas suptejas added medium-priority Managed by Dimension in-progress Managed by Dimension labels Jun 4, 2023 — with Dimension App
@haaarshsingh
Copy link

We'll take a look into this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request in-progress Managed by Dimension medium-priority Managed by Dimension
Projects
None yet
Development

No branches or pull requests

4 participants