Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

from_bevy_mesh doesn't support unindexed glTF #490

Open
rlidwka opened this issue Apr 1, 2024 · 0 comments · May be fixed by #491
Open

from_bevy_mesh doesn't support unindexed glTF #490

rlidwka opened this issue Apr 1, 2024 · 0 comments · May be fixed by #491
Labels
A-Geometry

Comments

@rlidwka
Copy link

rlidwka commented Apr 1, 2024

bevy_rapier/src/geometry/collider_impl.rs

Lines 739 to 743 in 6aa960b

fn extract_mesh_vertices_indices(mesh: &Mesh) -> Option<(Vec<na::Point3<Real>>, Vec<[u32; 3]>)> {
use rapier::na::point;
let vertices = mesh.attribute(Mesh::ATTRIBUTE_POSITION)?;
let indices = mesh.indices()?;

If mesh.indices() doesn't exist, function returns None.

Turns out, indices can be absent from glTF, and the file will still be valid. In this case, bevy Mesh wouldn't have any indices either (but bevy would display it just fine). You can search the internet by keywords "unindexed mesh gltf", and it's full of bug reports about lack of support from various projects...

I'm using osm2world, and it turns out that it generates unindexed meshes, so... Any ideas how to implement it?
rlidwka added a commit to rlidwka/bevy_rapier that referenced this issue Apr 2, 2024
@rlidwka
Add support for unindexed meshes in Collider::from_bevy_mesh
f8c2e58 
fixes dimforge#490
@rlidwka rlidwka linked a pull request Apr 2, 2024 that will close this issue
Open
rlidwka added a commit to rlidwka/bevy_rapier that referenced this issue May 11, 2024
@rlidwka
Add support for unindexed meshes in Collider::from_bevy_mesh
d2f869a 
fixes dimforge#490
rlidwka added a commit to rlidwka/bevy_rapier that referenced this issue Jul 15, 2024
@rlidwka
Add support for unindexed meshes in Collider::from_bevy_mesh
bf3cbe6 
fixes dimforge#490
rlidwka added a commit to rlidwka/bevy_rapier that referenced this issue Jul 15, 2024
@rlidwka
Add support for unindexed meshes in Collider::from_bevy_mesh
73fa110 
fixes dimforge#490
rlidwka added a commit to rlidwka/bevy_rapier that referenced this issue Oct 11, 2024
@rlidwka
Add support for unindexed meshes in Collider::from_bevy_mesh
18b4898 
fixes dimforge#490
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-Geometry
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add support for unindexed meshes in Collider::from_bevy_mesh rlidwka/bevy_rapier
2 participants
@rlidwka @Vrixyz