Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move mag and SNR cuts to the end after linking? #1083

Open
mschwamb opened this issue Dec 22, 2024 · 1 comment
Open

move mag and SNR cuts to the end after linking? #1083

mschwamb opened this issue Dec 22, 2024 · 1 comment
Labels
version 1.0 tasks that need to be completed before the first software release

Comments

@mschwamb
Copy link
Collaborator

mschwamb commented Dec 22, 2024

Right now the mag and SNR cuts occur before the fading function so you can't reliably using the linking filter. Especially with the new filter to cut out observations that are far in apparent magnitude before emphemeris generation, we don't really need to make post-processing faster that I think was the original intent. Note this is not the 2 SNR cut.

Where these cuts are placed this is good for checking if a known orbit will ever get bright enough to be potentially observed in past LSST observations, but you might want to simulate a Col-OSSOS sample and you can't do that. We also might want to give options for the mag cut whether it's median, max, min of all observations or the discovery observations.

@mschwamb mschwamb added the enhancement New feature or request label Dec 22, 2024
@mschwamb
Copy link
Collaborator Author

Also the mag limit cut is using the PSF mag, I think we want this to be the trailed source magnitude if we want to create a Col-OSSOS like sample - we should decide if want to change to trailed source magnitude

@mschwamb mschwamb added version 1.0 tasks that need to be completed before the first software release and removed enhancement New feature or request labels Dec 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
version 1.0 tasks that need to be completed before the first software release
Projects
None yet
Development

No branches or pull requests

1 participant