Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can "ev" in "should_call" be less than "0"? #2

Open
SergeyPetrovskiy opened this issue Jan 13, 2021 · 3 comments
Open

Can "ev" in "should_call" be less than "0"? #2

SergeyPetrovskiy opened this issue Jan 13, 2021 · 3 comments

Comments

@SergeyPetrovskiy
Copy link

Hello Diego.

Thank you for sharing of the code for this great tool! Regarding the issue. Maybe I have misunderstood something, but I am struggling to get proper case when in you function "should_call" the "ev" can be less than "0". Shouldn't it be more than "0" in all cases? Could you please advice?

def should_call(players,percentile,pot,price):
    pwin = (percentile/100)**players
    ev = pwin*pot
    if ev <= 0:
        print('you should fold')
    if ev > 0:
        print('You should bet as long as it is less than %s $' % ev)
    print('The expected value betting %s is %s $' % (price,ev-price))
    return pwin*100
@SergeyPetrovskiy
Copy link
Author

Shouldn't be there some other number instead of "0"?

@dirusali
Copy link
Owner

@SergeyPetrovskiy Thanks for your comment, you are right ev cannot be less than 0, what I meant there was actually not ev but ev - price, I have corrected that already in the repo, now you can see ev - price can be negative then you should not bet :)

@SergeyPetrovskiy
Copy link
Author

Thanks for the update, @dirusali !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants