Skip to content
This repository has been archived by the owner on Nov 15, 2022. It is now read-only.

there has some bugs. #15

Open
LiLong1105 opened this issue Apr 29, 2019 · 0 comments
Open

there has some bugs. #15

LiLong1105 opened this issue Apr 29, 2019 · 0 comments

Comments

@LiLong1105
Copy link

LiLong1105 commented Apr 29, 2019

it has unnecessary comma, and a error variable name.

`
def _get_proxy_url(self, ticket):
template = '{server_url}{auth_prefix}/proxy?'
template += 'targetService={proxy_callback}&pgt={ticket}'
url = template.format(
auth_prefix=self.auth_prefix,
proxy_callback=self.proxy_callback,
server_url=self.server_url,
ticket=ticket,#comma
)
return url

def _get_proxy_validate_url(self, ticket):
    template = '{validate_url}{auth_prefix}/proxy?'
    template += 'ticket={ticket}&service={proxy_callback}'
    url = template.format(
        auth_prefix=self.auth_prefix,
        proxy_callback=self.proxy_callback,
        validate=self.validate_url,#"validate" means "validate_url"
        ticket=ticket,#comma
        )
    return url

def _get_service_validate_url(self, ticket, service_url=None):
    template = '{validate_url}{auth_prefix}/serviceValidate?'
    template += 'ticket={ticket}&service={service_url}'
    url = template.format(
        auth_prefix=self.auth_prefix,
        validate_url=self.validate_url,
        service_url=service_url or self.service_url,
        ticket=ticket,#comma
        )
    if self.proxy_url:
        url = '{url}&pgtUrl={proxy_url}'.format(url, self.proxy_url)
    return url

`

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant