Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Typing] interaction.followUp() should not have ephemeral in its options? #10335

Closed
Zer0xxxx opened this issue Jun 7, 2024 · 6 comments
Closed

Comments

@Zer0xxxx
Copy link

Zer0xxxx commented Jun 7, 2024

Which package is this bug report for?

discord.js

Issue description

Currently, Discord.js allows to write this:

await interaction.followUp({ content: errorMsg, ephemeral: true });

(In my current code, interaction has the type: ChatInputCommandInteraction)

This has already been discussed here, and the "API limitation" concern is still relevant since I had the same problem today: #5702

Therefore, I think that the typing should invalidate the use of this option.
Current typing is misleading: it suggests that you can do a followUp with an ephemeral, whereas in practice this is not true.

Code sample

No response

Versions

discord.js : 14.15.3

Issue priority

Low (slightly annoying)

Which partials do you have configured?

Not applicable

Which gateway intents are you subscribing to?

Not applicable

I have tested this issue on a development release

No response

@Jiralite
Copy link
Member

Jiralite commented Jun 7, 2024

Current typing is misleading: it suggests that you can do a followUp with an ephemeral, whereas in practice this is not true.

Sounds like you are following up on a deferred response and assumed this to be not true. Follow-ups can happen after the initial response and may be ephemeral.

@Jiralite Jiralite closed this as not planned Won't fix, can't repro, duplicate, stale Jun 7, 2024
@Zer0xxxx
Copy link
Author

Zer0xxxx commented Jun 7, 2024

Current typing is misleading: it suggests that you can do a followUp with an ephemeral, whereas in practice this is not true.

Sounds like you are following up on a deferred response and assumed this to be not true. Follow-ups can happen after the initial response and may be ephemeral.

Oh, okay!
Then, what do you think about this one? @Jiralite

It sounds like a type intersection is missing for this case.

image

@Zer0xxxx
Copy link
Author

Zer0xxxx commented Jun 7, 2024

@Jiralite ?

@monbrey
Copy link
Member

monbrey commented Jun 7, 2024

There's absolutely no need to ping someone twice in less than two hours.

I'd rather not have to split the type that followUp accepts based on a stateful parameter.

@Zer0xxxx
Copy link
Author

Zer0xxxx commented Jun 8, 2024

There's absolutely no need to ping someone twice in less than two hours.

I'd rather not have to split the type that followUp accepts based on a stateful parameter.

There's absolutely no need to close an issue as not planned in less than 2 minutes. Especially when the issue is totally related to the SDK.
Peace.

@monbrey
Copy link
Member

monbrey commented Jun 8, 2024

That is the answer though. We don't plan to change this.

@discordjs discordjs locked and limited conversation to collaborators Jun 8, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants