Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

source code should be included with packages on npm #9693

Open
DetachHead opened this issue Jul 10, 2023 · 2 comments
Open

source code should be included with packages on npm #9693

DetachHead opened this issue Jul 10, 2023 · 2 comments

Comments

@DetachHead
Copy link

Which package is this bug report for?

discord.js

Issue description

from #9481:

Selected builders cuz it's the one I noticed the issue in but it applies to all TS packages. Basically the .js.map files are being sent to npm, which then breaks error stacks for people with source map support enabled since you can't Ctrl + click the file paths as they lead to the .ts files which are not in your directory.

re-raising because the original issue suggested removing the source maps instead of including the source code. see my comment #9481 (comment):

the source maps should stay in the npm package, but the source code should be included too. that way, ctrl+click would work and show the source code instead of the compiled js

Code sample

No response

Versions

discord.js 14.11.0

Issue priority

Low (slightly annoying)

Which partials do you have configured?

Not applicable

Which gateway intents are you subscribing to?

Not applicable

I have tested this issue on a development release

No response

@didinele
Copy link
Member

As stated here, this is not happening.

@didinele didinele closed this as not planned Won't fix, can't repro, duplicate, stale Jul 10, 2023
@didinele
Copy link
Member

Never mind actually, I miss read.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants