Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The container list block shouldn't hardcode the object path #84

Open
ctgraham opened this issue Mar 30, 2022 · 0 comments · May be fixed by #85
Open

The container list block shouldn't hardcode the object path #84

ctgraham opened this issue Mar 30, 2022 · 0 comments · May be fixed by #85

Comments

@ctgraham
Copy link

The jstreebuilder hardcodes the reference to the object's URL when building the tree:

$to_return['a_attr']['href'] = url("islandora/object/{$this->object->id}", array('fragment' => $to_return['id']));

But this block will be rendered on the page displaying that object, and the page could be arbitrarily aliased.

If aliased, these links will redirect to the /islandora/object/path unnecessarily, rather than creating a self-referential anchor, as intended.

ctgraham added a commit to ulsdevteam/islandora_solution_pack_manuscript that referenced this issue Mar 30, 2022
@ctgraham ctgraham linked a pull request Mar 30, 2022 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant