Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The button component does not import correctly #170

Open
kgudim opened this issue Apr 26, 2024 · 1 comment
Open

The button component does not import correctly #170

kgudim opened this issue Apr 26, 2024 · 1 comment

Comments

@kgudim
Copy link

kgudim commented Apr 26, 2024

The button component does not import correctly. Buttons are imported as a group of buttons. This could potentially be our implementation in Storybook?


Bug report identity: Please do not edit

Task path: YytzbsMl5rszMeUq0PC2/lSLaPUL1sr0gTnV3PSOW/131qjllpdmr3g

@muryoh
Copy link
Member

muryoh commented May 2, 2024

Hi @kgudim , sorry about the late reply!

Yes indeed, your story currently contains all 5 buttons at once:
image

Ideally you'd want to have one button per story, and to have Storybook args controlling what variant of the button to be rendering

Now if you really wanted to, you could use the :selector special story.to.design arg to go and say "I want to capture this specific element of that story", that could work. But then you'd be subject to changes in the order of elements - I think it's not ideal, but if you really cannot make it so a single story only exposes a single button then that is possible. But it will make your setup more complex

Best regards,
Remy

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants