Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Surface Component Font import wrong weight #196

Closed
j9981 opened this issue Sep 23, 2024 · 3 comments
Closed

Surface Component Font import wrong weight #196

j9981 opened this issue Sep 23, 2024 · 3 comments

Comments

@j9981
Copy link

j9981 commented Sep 23, 2024

Surface Component Font import wrong weight

Thank you for fixing the previous issue. The current surface container can load the Decimal font, and the spacing issue is fixed.

However, it's imported incorrect heading font-weight. It's imported "Thin" instead of "Light" (which is the correct weight in our storybook).

Thank you for your help.

Related ticket: #193


Bug report identity: Please do not edit

Task path: hpPpNB3AXDmRHPrweEFJ/xPG4gSrdkxavICSJD1YU/1ndltxymuhq2b

@muryoh
Copy link
Member

muryoh commented Sep 30, 2024

Hi @j9981 and sorry for the delayed replied!

I am currently not able to reproduce, it seems to usse Decimal Light as expected:
image

However I may not be using exactly the same Decimal fonts you are using locally, maybe that could explain it

Could you please tell me what you're seeing in the Figma fonts picker for Decimal? This is what I'm seeing:
image

Basically 2 different fonts instead of a single Decimal one with 2 different styles

@j9981
Copy link
Author

j9981 commented Sep 30, 2024

Hi @muryoh , thank you for getting back to me.

Here is the screenshot of what I see in my Figma. We are currently only using two weights in our tokens and storybook for Decimal: Light and Book. All the headings should be using Light.
Screenshot 2024-09-30 at 1 53 38 PM

Our storybook is using Light Weight Decimal. I believe we didn't have anything set in Thin on Storybook.
Screenshot 2024-09-30 at 1 59 25 PM

@muryoh
Copy link
Member

muryoh commented Oct 1, 2024

Hi,

So indeed we do not have exactly the same fonts locally, that's why I cannot reproduce
I will look into fixing it 👍

@gqio gqio closed this as completed Oct 2, 2024
@gqio gqio closed this as completed Oct 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants