Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JSON API 1.1: return included array even if nothing is included #1109

Open
3 tasks done
sliverc opened this issue Nov 29, 2022 · 2 comments
Open
3 tasks done

JSON API 1.1: return included array even if nothing is included #1109

sliverc opened this issue Nov 29, 2022 · 2 comments
Labels

Comments

@sliverc
Copy link
Member

sliverc commented Nov 29, 2022

Description of feature request

Currently, when there are no included resources, there is no included key. However, as of JSON API 1.1 this is required and in older versions it is certainly allowed. So whenever a user has requested includes with the query parameter include an included key needs to be part of the result. But only then. If there is no include query parameter, no include should be added.

Checklist

  • Raised initially as discussion Adding support for JSON:API v1.1 #1092
  • This cannot be dealt with as a third party library. (We prefer new functionality to be in the form of third party libraries where feasible.)
  • I have reduced the issue to the simplest possible case.
@Anirudh3167 Anirudh3167 mentioned this issue Jun 4, 2023
5 tasks
@Anirudh3167
Copy link

#1153 has the enhancement

@Anirudh3167
Copy link

Anirudh3167 commented Jun 6, 2023

Hey @sliverc I have issued the PR #1153
Kindly review and merge it.
Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants