Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JSONRenderer does not extract includes from PolymorphicModelSerializer properly #1191

Closed
dmuseychuk-invgate opened this issue Dec 5, 2023 · 1 comment
Labels

Comments

@dmuseychuk-invgate
Copy link

When using PolymorphicModelSerializer with JSONRenderer, the extract_included method is retrieving the base polymorphic serializer instead of the specific serializer corresponding to the object instance. This results in the includes not being processed correctly, as the base polymorphic serializer is not equipped to handle the specifics of each derived instance.

It appears that the issue can be resolved by modifying the render method to correctly identify and use the appropriate serializer based on the object instance during the rendering process. This adjustment should enable includes to function as expected with polymorphic serializers.

if serializer is not None:
    # Extract root meta for any type of serializer
    json_api_meta.update(self.extract_root_meta(serializer, serializer_data))
    if getattr(serializer, "many", False):
        ...
    else:
        if isinstance(serializer, PolymorphicModelSerializer):
            resource_instance = serializer.instance
            serializer_class = serializer.get_polymorphic_serializer_for_instance(resource_instance)
            serializer = serializer_class(resource_instance, context=serializer.context)

            fields = utils.get_serializer_fields(serializer)
            ...
@sliverc
Copy link
Member

sliverc commented Dec 11, 2023

This seems to be a double post, so closing this in favor of #1190.

@sliverc sliverc closed this as completed Dec 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants