Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move logic from sandbox implementation ? #43

Open
jedie opened this issue Mar 4, 2019 · 2 comments
Open

move logic from sandbox implementation ? #43

jedie opened this issue Mar 4, 2019 · 2 comments
Labels

Comments

@jedie
Copy link
Contributor

jedie commented Mar 4, 2019

I think there is much needed logic in the sandbox implementation, isn't it?
I think it would be good to move as much out of it as possible.

@maerteijn
Copy link
Member

maerteijn commented Mar 5, 2019

The sandbox application is a starting point for your own custom implementation, and used to test the oscar_docdata package. It's not there to be a fully tested reusable application.

However, I also think some of the logic in the sandbox application should be available as reusable modules. But this requires time and effort which I'm not going to spend on this project (for now). I'm already pretty happy that the project works on Python 3.x and with the Docdata 1.3 XSD.

@jedie
Copy link
Contributor Author

jedie commented Mar 5, 2019

some of the logic in the sandbox application should be available as reusable modules

That's exactly what I meant.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants