Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

notify, subscribe and unsubscribe: all parameters must be serializable #138

Open
benjaoming opened this issue Dec 15, 2023 · 0 comments
Open

Comments

@benjaoming
Copy link
Member

Instead of boggling the user's mind with weather or not these parameters should be supplied as objects or FK integers etc, let's

  1. force that they are integers or strings (!)
  2. allow both model instances or integers or strings

Because of compatibility with Celery and such async runtimes, we should try to make these functions as dumb as possible. This will also help in cases where the arguments are received from a querystring, and we can skip resolving them before using them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant