Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bootstrap 5? #20

Open
cheesycod opened this issue Feb 2, 2021 · 28 comments
Open

Bootstrap 5? #20

cheesycod opened this issue Feb 2, 2021 · 28 comments
Labels
help wanted Extra attention is needed

Comments

@cheesycod
Copy link

@djibe when do u plan to add bootstrap 5

@djibe
Copy link
Owner

djibe commented Feb 2, 2021

Hi,

I'll have to dig into it.
But it's a huge work alone.
4.6 coming soon.

@Duplore
Copy link

Duplore commented Apr 2, 2021

@djibe i could help a tiny bit with css 😄

@djibe
Copy link
Owner

djibe commented Apr 2, 2021

Hi,
I have a baby incoming and cannot invest more on it now.
If I create the base files in a branch, can you work on it ?

@Duplore
Copy link

Duplore commented Apr 3, 2021

@djibe if you got a discord we can keep in contact and I would love to contribute my time

@djibe djibe added the help wanted Extra attention is needed label Apr 4, 2021
@djibe
Copy link
Owner

djibe commented Apr 4, 2021

Hi @Kloptoe , thanks for your participation.

What are your skills ?
What will be difficult is to bring the JavaScript plugins to ES6.

@Duplore
Copy link

Duplore commented Apr 4, 2021

i know css, html, Scss

@Duplore
Copy link

Duplore commented Apr 5, 2021

*still learning SCSS

@Duplore
Copy link

Duplore commented Apr 6, 2021

@djibe

@djibe
Copy link
Owner

djibe commented Apr 6, 2021

Hi.
Thanks.
I'll try setting the base for BS5.
However it is a totally new project architecture and technologies (Hugo, variables and latest CSS specs so it will require a lot of work)

@Duplore
Copy link

Duplore commented Apr 7, 2021

alright, do you got a discord if so that'll be great to keep contact in case I got anything to ask

@djibe
Copy link
Owner

djibe commented Apr 7, 2021

Well, Discord is not my Generation :D
Skype ? :D

@Duplore
Copy link

Duplore commented Apr 7, 2021

i'll download it ye

@Duplore
Copy link

Duplore commented Apr 7, 2021

got it now to figure out how to add you lmao

@Duplore
Copy link

Duplore commented Apr 9, 2021

@djibe

@djibe
Copy link
Owner

djibe commented Apr 9, 2021

add live:djibe89

@Duplore
Copy link

Duplore commented Apr 9, 2021

added @djibe

@stsrki
Copy link

stsrki commented May 2, 2021

The Bootstrap 5 is going to be needed soon for my project and I would also like to help with this if needed.

@djibe How do you plan to proceed with Bootstrap 5? Considering it is quite different from Bootstrap 4 I think creating a new repository would be the best option.

@djibe
Copy link
Owner

djibe commented May 2, 2021

Hi everyone.
Thanks for your messages.
I was hesitating to create a new repo. I will.

How should I name the project:

  • Bootstrap 5 Material
  • Material UI 5 for BS
  • Material for Bootstrap 5
  • Material UI for BS5

@stsrki
Copy link

stsrki commented May 3, 2021

Out of all, "Bootstrap 5 Material" is self-descriptive.

Other choices

  • BM5
  • BootMat5
  • Material5

@djibe
Copy link
Owner

djibe commented May 3, 2021

Repo created: https://github.com/djibe/bootstrap-5-material

I'll have to dig in and set the base for your contribution

@stsrki
Copy link

stsrki commented May 4, 2021

The initial PR with Bootstrap is created.

Can you make me a contributor on a repo? Or do you prefer I work on my own fork?

@stsrki
Copy link

stsrki commented May 4, 2021

@djibe Thanks for adding me as a contributor.

Regarding the previous PR, I might have made a mistake. Instead of adding a full Boostrap source, it might be better to use their own startup template and then only add Bootstrap as a dependency. See their guide https://getbootstrap.com/docs/5.0/customize/overview/

startup template at https://github.com/twbs/bootstrap-npm-starter

What do you think it the best approach? Since you have more experience with setting the project maybe you can make it faster. If not I can do it, although it would take more time :)

@djibe
Copy link
Owner

djibe commented May 4, 2021

Hi.

Thanks for the PR I did the same last night :D

Since we heavily modify the code I don't see how we can use it as a dependency.
What do you think ?

@djibe djibe pinned this issue May 4, 2021
@stsrki
Copy link

stsrki commented May 4, 2021

Well, having full source code with all documentation page have its benefits. But we will need to keep track of any changes in the main bootstrap repo. For now it can stay like this and later we can refactor if needed.

@djibe
Copy link
Owner

djibe commented May 6, 2021

@stsrki
Copy link

stsrki commented May 6, 2021

Just saw it earlier. I guess it is time to slowly start migrating :)

@ayoubkhan558-zz
Copy link

When you are planning to update to Bootstrap 5?

@djibe
Copy link
Owner

djibe commented Aug 14, 2021

Hi,
I won't be able to do this with 2 kids.
I could help, but can't be alone.

@djibe djibe unpinned this issue Jun 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

5 participants