-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bootstrap 5? #20
Comments
Hi, I'll have to dig into it. |
@djibe i could help a tiny bit with css 😄 |
Hi, |
@djibe if you got a discord we can keep in contact and I would love to contribute my time |
Hi @Kloptoe , thanks for your participation. What are your skills ? |
i know css, html, Scss |
*still learning SCSS |
Hi. |
alright, do you got a discord if so that'll be great to keep contact in case I got anything to ask |
Well, Discord is not my Generation :D |
i'll download it ye |
got it now to figure out how to add you lmao |
add live:djibe89 |
added @djibe |
The Bootstrap 5 is going to be needed soon for my project and I would also like to help with this if needed. @djibe How do you plan to proceed with Bootstrap 5? Considering it is quite different from Bootstrap 4 I think creating a new repository would be the best option. |
Hi everyone. How should I name the project:
|
Out of all, "Bootstrap 5 Material" is self-descriptive. Other choices
|
Repo created: https://github.com/djibe/bootstrap-5-material I'll have to dig in and set the base for your contribution |
The initial PR with Bootstrap is created. Can you make me a contributor on a repo? Or do you prefer I work on my own fork? |
@djibe Thanks for adding me as a contributor. Regarding the previous PR, I might have made a mistake. Instead of adding a full Boostrap source, it might be better to use their own startup template and then only add Bootstrap as a dependency. See their guide https://getbootstrap.com/docs/5.0/customize/overview/ startup template at https://github.com/twbs/bootstrap-npm-starter What do you think it the best approach? Since you have more experience with setting the project maybe you can make it faster. If not I can do it, although it would take more time :) |
Hi. Thanks for the PR I did the same last night :D Since we heavily modify the code I don't see how we can use it as a dependency. |
Well, having full source code with all documentation page have its benefits. But we will need to keep track of any changes in the main bootstrap repo. For now it can stay like this and later we can refactor if needed. |
Just saw it earlier. I guess it is time to slowly start migrating :) |
When you are planning to update to Bootstrap 5? |
Hi, |
@djibe when do u plan to add bootstrap 5
The text was updated successfully, but these errors were encountered: