Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

style test relies on adjacent dmd repo being present #335

Closed
MartinNowak opened this issue Nov 5, 2018 · 5 comments
Closed

style test relies on adjacent dmd repo being present #335

MartinNowak opened this issue Nov 5, 2018 · 5 comments
Labels

Comments

@MartinNowak
Copy link
Member

MartinNowak commented Nov 5, 2018

Fails with fresh on-demand agents when make -f posix.mak style tries to include ../dmd/osmodel.mak.
https://buildkite.com/dlang/phobos/builds/552#100bbbc3-6b0d-44af-861d-99a0791563dc
Just didn't happen on the long-running buildkite agents because they still had a previous dlang/dmd repo leftover.
The whole folder setup is quite messy atm. and we should consider to rewrite it, using a custom noop checkout hook and doing the checkouts manually into an empty working directory.
Checkout hooks can be installed on the agents under /etc/buildkite-agent/hooks/checkout.
This would also avoid checkouts for every project being tested.

@MartinNowak
Copy link
Member Author

@wilzbach

@wilzbach
Copy link
Member

This was fixed with #340. However, now it fails because DMD is segfaulting while building Dscanner.
This has been fixed at Dscanner and there's a PR to update Dscanner at Phobos: dlang/phobos#6783

@ghost
Copy link

ghost commented Nov 29, 2018

Yes this is coming. Maybe just a few filtering rules to adjust.

@wilzbach
Copy link
Member

wilzbach commented Dec 1, 2018

The whole folder setup is quite messy atm. and we should consider to rewrite it, using a custom noop checkout hook and doing the checkouts manually into an empty working directory.

Moved this to #358

@wilzbach
Copy link
Member

wilzbach commented Dec 3, 2018

Closing as I moved the main issue to #358 and the style test have been fixed.

@wilzbach wilzbach closed this as completed Dec 3, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants