Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix bugzilla 21995 Struct with size uint.max or greater causes ICE #16885

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix bugzilla 21995 Struct with size uint.max or greater causes ICE #16885

wants to merge 1 commit into from
+22 −6

Conversation

WalterBright
Copy link
Member

To its credit, the overflow at least was checked for!

@dlang-bot
Copy link
Contributor

Thanks for your pull request, @WalterBright!

Bugzilla references

Auto-close Bugzilla Severity Description
✓ 21995 critical Struct with size uint.max or greater causes ICE

⚠️⚠️⚠️ Warnings ⚠️⚠️⚠️

To target stable perform these two steps:

  1. Rebase your branch to upstream/stable:
git rebase --onto upstream/stable upstream/master
  1. Change the base branch of your PR to stable

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub run digger -- build "master + dmd#16885"

RazvanN7
RazvanN7 approved these changes Sep 27, 2024
View reviewed changes
Copy link
Contributor

@RazvanN7 RazvanN7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should target stable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ibuclaw ibuclaw ibuclaw left review comments

@RazvanN7 RazvanN7 RazvanN7 approved these changes

Assignees
No one assigned
Labels
Bug Fix Easy Review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@WalterBright @dlang-bot @ibuclaw @RazvanN7