-
-
Notifications
You must be signed in to change notification settings - Fork 227
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
dependencies with a platform suffix is silently accepted and the suffix ignored #1049
Comments
steps to reproduce from a Windows system: git clone https://github.com/rtbo/dub1049.git
cd dub1049
dub test |
I haven't run the repro case yet, but that behavior would really surprise me, because actually platform suffixes are not supported at all for dependencies. So it should really not include the dependency at all in this case (outputting a warning would be helpful but is not yet implemented). The intended way to get this working is to define separate configurations for each platform and put the platform specific dependencies in there. DUB will then still download them, but will only build those that are specified by the selected configuration. |
If I understand, dub should not even try to download and build the linux specific dependency because this is not the correct way for specifying such dependency! At least fixing my code will be easy, I will introduce configurations! |
Regarding the download issue, we have #1706 Changed the title accordingly. |
Will be fixed by #2280 |
This is essentially #614 , closing as duplicate. |
On cross-platform dub packages that has e.g. a
"dependencies-linux"
entry indub.json
, dub tries to build the dependencies also on non-linux systems.This makes building the package eventually fail if the dependency isn't meant to be built on a non-linux system.
The text was updated successfully, but these errors were encountered: