Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add vary heade to flat and hierarchical collection GETs #52

Merged
merged 1 commit into from
Sep 26, 2024

Conversation

p-kaczynski
Copy link
Contributor

image

Array can be expanded or moved to config if anything like that ever becomes necessary.

Attr can be easily modified to take the string[] headerNames in ctor, if we ever need to vary the vary header in various actions 😆

For now took the simple approach. Well, simple would be to add Response.Headers.Append in the actions themselves, but you know, that's awful :D

Copy link
Collaborator

@JackLewis-digirati JackLewis-digirati left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@p-kaczynski p-kaczynski merged commit 0fe302a into main Sep 26, 2024
3 checks passed
@p-kaczynski p-kaczynski deleted the feature/19/vary_header branch September 26, 2024 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants