Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replies to cover letter should be shown on series page #159

Open
ruscur opened this issue Mar 2, 2016 · 1 comment
Open

Replies to cover letter should be shown on series page #159

ruscur opened this issue Mar 2, 2016 · 1 comment
Labels
UI/series page UI

Comments

@ruscur
Copy link

ruscur commented Mar 2, 2016

If there are replies to the cover letter of a patch series, they should show up in a comments section of the series page just as they do on patches.
belenbarrospena pushed a commit to belenbarrospena/patchwork-redesign that referenced this issue Mar 2, 2016
Show replies to series cover letter
9a8cb65 
This GitHub issue

dlespiau/patchwork#159

suggests we should show replies to the cover letter email. We can do
that in the series detail page, in the 'Cover' tab.

Signed-off-by: Belen Barros Pena <[email protected]>
@belenbarrospena
Copy link
Collaborator

The redesign of the series page does not have a comments section for series, but they could show below the cover letter itself. Like so

http://belenbarrospena.github.io/patchwork-redesign/series-r4.html#comment1

Let me know if that would work. By the way, if you people have any feedback on the new series details page

http://belenbarrospena.github.io/patchwork-redesign/series-r4.html

Or the patch page

http://belenbarrospena.github.io/patchwork-redesign/patch1.html

Do let me know. They are not implemented yet, so we have time for improvements.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
UI/series page UI
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@dlespiau @belenbarrospena @ruscur