Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add filtering by file path in 'git-pw list' #160

Open
robclark opened this issue Mar 2, 2016 · 2 comments
Open

Add filtering by file path in 'git-pw list' #160

robclark opened this issue Mar 2, 2016 · 2 comments

Comments

@robclark
Copy link

robclark commented Mar 2, 2016

Vaguely connected to #139 but I didn't want to hijack that issue.

With pwclient I do (for example) 'pwclient list msm' to list just patches w/ msm in the subject. It would be nice to be able to do similar. Although perhaps even better would be filtering on path (so you could just list the driver path(s) that you are interested in and see all the patches that touch the driver/subsystem/etc that you maintain.

@dlespiau
Copy link
Owner

dlespiau commented Mar 3, 2016

So the first part of the feature request was easy and is done.

The search by path touched is interesting, I'll leave the issue open for that part. We don't currently stored anything more than the whole text of the patch which doesn't map well with SQL and search in text blobs. The easier way to go about it would be to store more structured data about the patches (probably a number of 'Hunk' objects which would represent the diff hunks of the patch) and search through that data.

Definitely a direction I'd love to go towards to.

@dlespiau dlespiau changed the title Add filtering by subject and/or path in 'git-pw list' Add filtering by file path in 'git-pw list' Mar 3, 2016
@robclark
Copy link
Author

robclark commented Mar 3, 2016

ahh, cool.. I was hoping git already had some nice way to give you the changed paths (ie. similar to the --stat arg).. although I guess you want some way to get that from the server without having to download all the patches.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants