Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feedback from Anirban #6

Open
2 of 7 tasks
rayanirban opened this issue Aug 2, 2023 · 0 comments
Open
2 of 7 tasks

Feedback from Anirban #6

rayanirban opened this issue Aug 2, 2023 · 0 comments
Assignees

Comments

@rayanirban
Copy link
Member

rayanirban commented Aug 2, 2023

  • There could be optional ways of exploring the data folders (eg. using seedir library in Python or something similar).
  • The exercise to find the total number of pairs in the data folders and their extension (in case you want to keep it) could be a good learning exercise for the students but I would recommend some starting instructions.
  • The assert of hash to check correctness may be removed because of unpredictable output based on the environment.
  • In the NucleiDataset class, I would recommend some more explanation of the three different types of transforms that re being used.
  • In the show_random_dataset_image function in the solutions.ipynb I would recommend that the solution incorporated an additional default parameter idx=None that might be used to visualize a particular image.
  • After checkpoint 1, you might want to give students some options to play around with the GaussianBlur augmentation by allowing them to change the RandomCrop and the GaussianBlur parameters and plot the different images together.
  • I recommend doing the assert cuda() at an initial stage of the notebook.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants