Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for local signer #11

Open
ryanc414 opened this issue Apr 26, 2022 · 0 comments
Open

Add support for local signer #11

ryanc414 opened this issue Apr 26, 2022 · 0 comments

Comments

@ryanc414
Copy link

Hey, this looks like a really useful library as getting permit txs right can be confusing!

It seems to me that the library is designed to be used on the client-side in conjunction with a remote signer. However sometimes it is useful to sign transactions from the backend, using e.g. https://github.com/MetaMask/eth-sig-util. It would be useful if there was a function within eth-permit which constructed the typedData and returned it without signing, allowing the calling code to decide how it should be signed.

I think this could be achieved by exporting the createTypedERC2612Data function as public, and similar for the Dai version. What do you think?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant