Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

argparse dependency unnecessary #195

Open
lukegb opened this issue Sep 21, 2024 · 3 comments
Open

argparse dependency unnecessary #195

lukegb opened this issue Sep 21, 2024 · 3 comments
Labels
bug Something isn't working

Comments

@lukegb
Copy link

lukegb commented Sep 21, 2024

Before opening an issue make sure that there are no duplicates and that you are on the latest version.
Describe the bug
argparse is listed in requrements.txt, but not used at all.

To Reproduce
Steps to reproduce the behavior:

  1. Open requirements.txt

Expected behavior
argparse to not be included.

Screenshots
image

iSponsorBlockTV server (please complete the following information):

  • OS: [e.g. Docker on linux Arm64, windows]
  • Python version [e.g. 3.7] (no need to fill if running on docker

Apple TV (please complete the following information):

  • Device: [e.g. Apple TV 4]
  • OS: [e.g. tvOS 15.4]

Additional context
Add any other context about the problem here.

@lukegb lukegb added the bug Something isn't working label Sep 21, 2024
@lukegb
Copy link
Author

lukegb commented Sep 21, 2024

For context: argparse does not appear to be used by this repo directly at all, and also argparse has been in the Python standard library since 3.2.

@dmunozv04
Copy link
Owner

Thanks for opening the issue, I forgot to remove it when I migrated the cli to click. I’ll get it fixed on #194

@lukegb
Copy link
Author

lukegb commented Sep 21, 2024

Thanks!

dmunozv04 added a commit that referenced this issue Sep 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants