Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

--mash-distance outputs similarity with --set option #45

Open
dejsha opened this issue Nov 30, 2021 · 3 comments · Fixed by #46
Open

--mash-distance outputs similarity with --set option #45

dejsha opened this issue Nov 30, 2021 · 3 comments · Fixed by #46

Comments

@dejsha
Copy link

dejsha commented Nov 30, 2021

Hi, with version 2.1.9 binaries, I keep getting similarity matrix instead of distance matrix when using:
./dashing2_s128 sketch --cmpout distance.txt -F paths.txt -p16 -k31 --set --mash-distance
I.e. the distance.txt output is identical (with ones at diagonal) as for similariry.txt produced with:
./dashing2_s128 sketch --cmpout similariry.txt -F paths.txt -p16 -k31 --set
If I do weighted distance:
./dashing2_s128 sketch --cmpout distance.txt -F paths.txt -p16 -k31 --prob --mash-distance
It seems works correctly - I recieve distance matrix (which has -0 at diagonal).
How could I get mash distance with --set?
Thank you very much, dasa

@dnbaker
Copy link
Owner

dnbaker commented Nov 30, 2021

Hi dejsha,

Thanks for your bug report! You're right - Dashing2 is ignoring the distance metric for the --set option. This is also the case for weighted Jaccard (--countdict).

I'll get this patched up and let you know.

Best,

Daniel

@dnbaker
Copy link
Owner

dnbaker commented Nov 30, 2021

Hi,

I've found and corrected the bug. I've merged it into main, and I'll let you know when the new binary releases are available.

Thanks,

Daniel

@dnbaker dnbaker reopened this Nov 30, 2021
@dnbaker
Copy link
Owner

dnbaker commented Nov 30, 2021

New binaries are out -

You can fetch them from https://github.com/dnbaker/dashing2-binaries or from the tarball release https://github.com/dnbaker/dashing2-binaries/archive/refs/tags/v2.1.10.tar.gz.

Thanks again,

Daniel

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants