Change "All Users" to "Everyone" #6120
Conversation
There was a problem hiding this comment.
This is not a simple change, "All Users" is in a lot of places and if this is not done everywhere we'll have inconsistant naming, causing more confusing than the current state.
Furthermore, there might be many 3rd party modules that might be locating that role by name (not saying it is right), but it has the potential to be a breaking change for those 3rd party extensions.
See https://github.com/search?q=repo%3Adnnsoftware%2FDnn.Platform%20%22All%20Users%22&type=code for a seach on "All Users" for a clue of where it is used
|
The role name should be localized in all scenarios (see #6119 that @Timo-Breumelhof also opened). Changing the localized text should be a completely safe change. So, once #6119 is resolved, this should be a pretty clean and safe change. |
|
Good point, however I would still prefer we handle all of "All Users" localization everywhere in one PR. It is referenced in a couple of localization paragraphs and I'd prefer it is named the same everywhere to avoid making it even more confusing if it is "All Users" in some places and "Everyone" in other places. |
|
Closed as superseded by #6133 |
fixes #6091
Summary
This must be the simplest PR in our history? ;-)
I edited SharedResources.resx to replace "All Users" with "Everyone".
But there's one issue remaining, the Persona Bar does not use this resource key, in there "All Users" is hard coded.
So IMO we should only implement this one if #6119 is fixed too..